Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMP] Worlds #548

Merged
merged 18 commits into from
Apr 30, 2024
Merged

[COMP] Worlds #548

merged 18 commits into from
Apr 30, 2024

Conversation

MattD8957
Copy link
Contributor

Closes #547

@MattD8957 MattD8957 added this to the [COMP] Worlds milestone Apr 30, 2024
@MattD8957 MattD8957 self-assigned this Apr 30, 2024
Copy link
Contributor Author

@MattD8957 MattD8957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Someone else should review too

@WindowsVistaisCool WindowsVistaisCool changed the title Comp worlds [COMP] Worlds Apr 30, 2024
Copy link
Member

@WindowsVistaisCool WindowsVistaisCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

@@ -107,7 +107,6 @@ public class RobotContainer extends LightningContainer {
Telemetry logger;

private Boolean triggerInit;
private boolean notePassOnTarget = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this being used anywhere?

@WindowsVistaisCool WindowsVistaisCool merged commit 6180f26 into main Apr 30, 2024
5 checks passed
@WindowsVistaisCool WindowsVistaisCool deleted the COMP-Worlds branch April 30, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worlds
2 participants